Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release/285.0.0 #5173

Merged
merged 3 commits into from
Jan 17, 2025
Merged

Release/285.0.0 #5173

merged 3 commits into from
Jan 17, 2025

Conversation

Bigshmow
Copy link
Contributor

@Bigshmow Bigshmow commented Jan 17, 2025 •
edited
Loading

Explanation

This release will expose the first iteration of token-search-discovery-controller v1.0.0.

Reviewing Release PRs

  • Are there any packages with version bumps that should not be published?
  • For all packages being published:
    • Does the new version string sufficiently communicate the impact of changes?
    • Are there any changelog entries that do not need to be listed?
    • Are there any changelog entries that are placed in the wrong category (including "Unreleased")?
    • Do all changelog entries explain the changes in a clear and straightforward manner and detail exact changes to the package's interface?
    • Do all change entries include a link to the pull requests where that change was made?
    • Are there any changes since the package's previous release that are not reflected in the changelog?
    • Have there been any changes merged to main while the release PR has been open that have not been added to a changelog?
    • Are there any bumps to workspace dependencies made within the release PR that have not been captured in the changelog?

References

Changelog

@metamask/token-search-discovery-controller

  • Added: More detail of the initial release in the changelog

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@Bigshmow Bigshmow marked this pull request as ready for review January 17, 2025 17:16
@Bigshmow Bigshmow requested review from a team as code owners January 17, 2025 17:16
mcmire
mcmire approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@Bigshmow Bigshmow merged commit 409e083 into main Jan 17, 2025
122 checks passed
@Bigshmow Bigshmow deleted the release/285.0.0 branch January 17, 2025 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcmire mcmire mcmire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bigshmow @mcmire